Vehicle Locking

  • Offline ShineDwarf
  • First Blood
  • ***
  • Posts: 53
  • Consul-Fractured Gaming

Vehicle Locking

« posted: Jan 03, 2018, 12:20 AM »
Hey guys,

Just updated in the new commits, has anyone had any issues with vehicles not locking properly?
Prior to updates locking worked, but we were having instance of opposing factions being able to enter any players vehicles regardless of ownership.

Now they are unable to, but indy players are able to enter any other indy players vehicle with "lock vehicle" not changing to "unlock vehicle"


https://github.com/Fractured-Gaming-Official/Frac_v1.3.New.Stratis/commit/19c3d826b0df5bf6382f7529ae079c5d585d314b

Commits are combined with all the recent ones so its a bit of a read sorry in advance.
  • Offline AgentRev
  • Developer
  • Veteran
  • ******
  • Posts: 2424

Re: Vehicle Locking

« Reply #1 posted: Jan 03, 2018, 08:54 AM »
I forgot to tell you, I got a bunch of script errors on the welcome screen each time I connected onto your server, prior and after your update. With your most recent code, I can see 4 errors:

Misplaced semicolon
https://github.com/Fractured-Gaming-Official/Frac_v1.3.New.Stratis/blob/19c3d826b0df5bf6382f7529ae079c5d585d314b/client/clientEvents/getInVehicle.sqf#L51

Copypaste mistake
https://github.com/Fractured-Gaming-Official/Frac_v1.3.New.Stratis/blob/19c3d826b0df5bf6382f7529ae079c5d585d314b/client/clientEvents/getOutVehicle.sqf#L24

Copypaste mistake
https://github.com/Fractured-Gaming-Official/Frac_v1.3.New.Stratis/blob/19c3d826b0df5bf6382f7529ae079c5d585d314b/server/functions/fn_setLockState.sqf#L26

You forgot to comment this line, which causes an error because it can't find the Demining UAV price
https://github.com/Fractured-Gaming-Official/Frac_v1.3.New.Stratis/blob/19c3d826b0df5bf6382f7529ae079c5d585d314b/storeConfig.sqf#L968

You should always run your game with -showScriptErrors, also this is just for the client, you might want to check the server RPT too.

If you're gonna keep updating your code using Virgin Copypaste instead of Chad Git Merge, the least you can do is click the "Raw" button on GitHub before copying so you don't overselect by mistake.
  • Offline ShineDwarf
  • First Blood
  • ***
  • Posts: 53
  • Consul-Fractured Gaming

Re: Vehicle Locking

« Reply #2 posted: Jan 03, 2018, 09:49 AM »
Fixed, fixed, fixed, and fixed.

Thanks Rev,

Still working on the finer details on what im doing, activated '-showscripterrors' so I'll be able to track things down faster, ill get my admins to do the same to keep us posted.

Dont really have a good answer as to why it wasnt set up for git merge when we remade the server, but ill set it up tomorrow.

Other then the above, the only thing I noticed on our server rpt is:

Code: [Select]
0:54:58 Server: Object 2:1286 not found (message Type_93)
 0:54:59 Error in expression <s - _oldIDs;

[_oldIDs, _objCount] call fn_postObjectSave;

if (_isHC) then { "A>
 0:54:59   Error position: <fn_postObjectSave;

if (_isHC) then { "A>
 0:54:59   Error Undefined variable in expression: fn_postobjectsave
 0:54:59 File mpmissions\__cur_mp.Stratis\persistence\server\world\oSave.sqf, line 85
 0:55:00 Server: Object 2:1285 not found (message Type_93)
 0:55:00 Server: Object 2:1286 not found (message Type_93)
 0:55:02 Server: Object 2:1286 not found (message Type_121)

Looking at the current osave file though it appears to match ours.

Thanks again though!

Shine.
  • Offline AgentRev
  • Developer
  • Veteran
  • ******
  • Posts: 2424

Re: Vehicle Locking

« Reply #3 posted: Jan 03, 2018, 09:51 AM »
On a different note, it would be nice if you could change this uisleep 5 to uisleep 1
https://github.com/Fractured-Gaming-Official/Frac_v1.3.New.Stratis/blob/0fab42894cce349cb466cc3e545b80a63b09c5cb/addons/statusBar/statusBar.sqf#L23

This will make the status bar update faster.
  • Offline ShineDwarf
  • First Blood
  • ***
  • Posts: 53
  • Consul-Fractured Gaming

Re: Vehicle Locking

« Reply #4 posted: Jan 03, 2018, 09:54 AM »
On a different note, it would be nice if you could change this uisleep 5 to uisleep 1
https://github.com/Fractured-Gaming-Official/Frac_v1.3.New.Stratis/blob/0fab42894cce349cb466cc3e545b80a63b09c5cb/addons/statusBar/statusBar.sqf#L23

This will make the status bar update faster.

Done
  • Offline AgentRev
  • Developer
  • Veteran
  • ******
  • Posts: 2424

Re: Vehicle Locking

« Reply #5 posted: Jan 03, 2018, 10:04 AM »
Other then the above, the only thing I noticed on our server rpt is

Can I have the full RPT?
  • Offline ShineDwarf
  • First Blood
  • ***
  • Posts: 53
  • Consul-Fractured Gaming

Re: Vehicle Locking

« Reply #6 posted: Jan 03, 2018, 10:09 AM »
Sorry had to grab it from the dedi.

This will still have the first 4 errors as restart hasnt occurred yet for new updates, otherwise most current.
  • Offline AgentRev
  • Developer
  • Veteran
  • ******
  • Posts: 2424

Re: Vehicle Locking

« Reply #7 posted: Jan 03, 2018, 10:44 AM »
Can I see your main_config.sqf?
  • Offline ShineDwarf
  • First Blood
  • ***
  • Posts: 53
  • Consul-Fractured Gaming

Re: Vehicle Locking

« Reply #8 posted: Jan 03, 2018, 10:55 AM »
Pm'dd
  • Offline AgentRev
  • Developer
  • Veteran
  • ******
  • Posts: 2424

Re: Vehicle Locking

« Reply #9 posted: Jan 03, 2018, 11:09 AM »
Didn't get it...
  • Offline ShineDwarf
  • First Blood
  • ***
  • Posts: 53
  • Consul-Fractured Gaming

Re: Vehicle Locking

« Reply #10 posted: Jan 03, 2018, 11:36 AM »
Whoops...should be there now..
  • Offline AgentRev
  • Developer
  • Veteran
  • ******
  • Posts: 2424

Re: Vehicle Locking

« Reply #11 posted: Jan 03, 2018, 11:39 AM »
Ok so I never factored in the possibility that someone would completely disable object saving. There is an object saving condition check when compiling fn_postobjectsave, but none when calling it, so it's being called even if not compiled. Since object saving is disabled, don't worry about it.
  • Offline ShineDwarf
  • First Blood
  • ***
  • Posts: 53
  • Consul-Fractured Gaming

Re: Vehicle Locking

« Reply #12 posted: Jan 03, 2018, 11:41 AM »
Ahhhhh alright.

Thanks Rev
  • Offline AgentRev
  • Developer
  • Veteran
  • ******
  • Posts: 2424

Re: Vehicle Locking

« Reply #13 posted: Jan 06, 2018, 04:40 AM »
also you didn't change the correct uisleep in statusBar.sqf, it's the second one, as referenced in the URL (Line 23)
  • Offline ShineDwarf
  • First Blood
  • ***
  • Posts: 53
  • Consul-Fractured Gaming

Re: Vehicle Locking

« Reply #14 posted: Jan 06, 2018, 06:06 AM »
feck sorry  Rev,

Edited it now, and will push out when im done work.