Exploit at selling vehicule/object on crate and private garage

A player alert us because he found a possible exploit wtih fast clik software.

I would like to known if a solution is possible, for exemple a cooldown  (with a sleep) after action selling vehicle/object and store vehicle at private garage can be added to prevent this exploit?

Re: Exploit at selling vehicule/object on crate and private garage

« Reply #1 posted: Mar 02, 2022, 08:13 PM »
No one have an idea to fix this exploit?

Re: Exploit at selling vehicule/object on crate and private garage

« Reply #2 posted: Mar 02, 2022, 10:13 PM »
I think if you put infistar avoid these exploits
  • Offline LeonZ
  • github.com/LeonZ2019/Lucky-s-Wasteland-Server
  • First Blood
  • ***
  • Posts: 71

Re: Exploit at selling vehicule/object on crate and private garage

« Reply #3 posted: Mar 03, 2022, 07:12 AM »
Not sure what exploit you are talking about, maybe you can elaborate it
LeonZ#1848 on Discord

Re: Exploit at selling vehicule/object on crate and private garage

« Reply #4 posted: Mar 03, 2022, 07:22 AM »
Sounds like an exploit that used to be around a long time ago. Which allowed server lag to allow the player to press sell multiple times before the server completed the first action. It could allow multiple sales of the same object. I think it was fixed several versions ago though.

The server you're on might not be using the most up to date code for these points of sale, since garage and crate sales aren't part of default wasteland.

Re: Exploit at selling vehicule/object on crate and private garage

« Reply #5 posted: Mar 03, 2022, 09:26 AM »
yes this is the problem, players use fastclik software when selling vehicule, and they will able to sell it twice. With private garage it's the same, they can park 2 times same vehicle (duplication).

We have heavely customized Wasteland mission, i will compare vanillia and our version to see if we have différence with selling/storage system.

If someone know wich file is used for that i will appréciate ;) Thanks

Re: Exploit at selling vehicule/object on crate and private garage

« Reply #6 posted: Mar 03, 2022, 11:44 AM »
i'm up to date with client\systems\selling\ all files are smae as actual vanillia version

Re: Exploit at selling vehicule/object on crate and private garage

« Reply #7 posted: Mar 09, 2022, 08:15 PM »
Still no solution to avoid this exploit?

Players can exploit this without any server lags , we tested with only 3 players on server, 48fps server.
  • Offline h4wk
  • Geared Up
  • **
  • Posts: 24

Re: Exploit at selling vehicule/object on crate and private garage

« Reply #8 posted: Mar 14, 2022, 03:14 AM »
you could add to the sellVehicle.sqf at very bottom above the the last }; a
Code: [Select]
sleep 0.25;
and in the file pp_saving_functions.sqf

below the line 160 or
Code: [Select]
[_player, format["%1, your %2 has been parked.", (name _player), _display_name]] call pp_notify;
    };
another
 
Code: [Select]
sleep 0.25;

Re: Exploit at selling vehicule/object on crate and private garage

« Reply #9 posted: Mar 14, 2022, 08:03 AM »
Thanks! I already add sleep for selling and it works fine.
I will follow your tips for private storage.
  • Offline h4wk
  • Geared Up
  • **
  • Posts: 24

Re: Exploit at selling vehicule/object on crate and private garage

« Reply #10 posted: Mar 16, 2022, 09:03 PM »
buyAmmo.sqf

at line 94

another sleep 0.25; before the };